Review Request 129246: validate_svg: Increase portability

Raphael Kubo da Costa rakuco at FreeBSD.org
Sun Oct 23 15:28:33 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129246/
-----------------------------------------------------------

Review request for KDE Frameworks and Jos van den Oever.


Repository: breeze-icons


Description
-------

- Instead of hardcoding the call to the xmllint binary, look for it in
  CMake first and pass its full path to validate_svg.sh.
- Stop creating xmlerrors in the source tree, which is not removed when
  there are no errors in the validation.
- Switch to sh(1) instead of requiring bash, we are just invoking
  find(1) and there is nothing bash-specific in the script.
- Stop setting SVGS in CMake. It increases the configuration time while
  providing no benefit other than perhaps adding the SVG files to an IDE
  project.


Diffs
-----

  CMakeLists.txt 2591a3a0c9c397a729243ceb414251f296895888 
  validate_svg.sh adaf26f95a645b57f8a588fdd49d2281f24b684a 

Diff: https://git.reviewboard.kde.org/r/129246/diff/


Testing
-------

Configuration continues to work, as well as the `breeze-validate-svg` continues working.


Thanks,

Raphael Kubo da Costa

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161023/1a8868aa/attachment.html>


More information about the Kde-frameworks-devel mailing list