Review Request 121283: Allow using new style connect in KActionCollection::add[Action]()
David Faure
faure at kde.org
Sun Oct 23 13:59:01 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121283/#review100218
-----------------------------------------------------------
Ship it!
Looks good to me -- just remember to update the version number in the two @since lines, before pushing.
- David Faure
On Feb. 26, 2015, 6:49 p.m., Alex Richardson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121283/
> -----------------------------------------------------------
>
> (Updated Feb. 26, 2015, 6:49 p.m.)
>
>
> Review request for KDE Frameworks, David Faure and Nicolás Alvarez.
>
>
> Repository: kxmlgui
>
>
> Description
> -------
>
> Allow using new style connect in KActionCollection::add[Action]()
>
>
> Diffs
> -----
>
> src/kactioncollection.h 5ff9a7781a4455c5d1ed79d366efd290f0879e9d
>
> Diff: https://git.reviewboard.kde.org/r/121283/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Richardson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161023/17fd6bb3/attachment.html>
More information about the Kde-frameworks-devel
mailing list