Review Request 118366: Porting keyboard module to Framework5

[shivam makkar]

> On Oct. 21, 2016, 11:12 a.m., Albert Astals Cid wrote:
> > Seems this was somehow forgotten, sadly the patch does not apply anymore (or maybe it was commited and this was never closed?).
> > 
> > Could you either upload a new patch if it's still needed or close the review if it is now?

The porting has been done, I guess it was tracked in some other cr.
Therefore discarding.


- shivam


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118366/#review100194
-----------------------------------------------------------


On June 23, 2014, 1:46 p.m., shivam makkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118366/
> -----------------------------------------------------------
> 
> (Updated June 23, 2014, 1:46 p.m.)
> 
> 
> Review request for kde-workspace, KDE Frameworks and Andriy Rysin.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> Removed deprecated statements and ported keyboard module to framework 5.
> 
> 
> Diffs
> -----
> 
>   kcms/keyboard/bindings.h c5764556d97e06ebad4f1737ffbbea2981ff32ca 
>   kcms/keyboard/bindings.cpp 21541e095da0b8d6ea1f789644f6e09d577c298b 
>   kcms/keyboard/flags.cpp b768586cc644fc5750245a8b1c3db4c55a43c16e 
>   kcms/keyboard/iso_codes.h 6a337392e958546e9f36423d7e3fd10d9e12c6f8 
>   kcms/keyboard/iso_codes.cpp 3e3b210b9f0f89c71a04535e74bd43b6b3b243e9 
>   kcms/keyboard/kcm_keyboard.cpp 42b7fe4df5fddd9ae738cde62d0c9e8a3dcad103 
>   kcms/keyboard/kcm_keyboard.ui 0062d1c53877f13d0036c0220691347434a9d47f 
>   kcms/keyboard/kcm_keyboard_widget.h 657ddda3bc1d75a632a6ddbd1a9ec690b6244909 
>   kcms/keyboard/kcm_keyboard_widget.cpp 21685eb527b7fd1d8a322d0e17ae2c0ae291ce41 
>   kcms/keyboard/kcmmisc.h 411bdd2b0f61257b4382fe35be4b8fa4ea2ecba6 
>   kcms/keyboard/kcmmisc.cpp 6f787ea3723f223537252b9581c15db203f4764c 
>   kcms/keyboard/kcmmiscwidget.ui 37fbaf4b9c9af9a62713bb9b5444cc04320e8d53 
>   kcms/keyboard/keyboard_config.h b86418de47a83e75eb85e723cc8eb24071e1f43d 
>   kcms/keyboard/keyboard_config.cpp f3ff97ca84d444acfb215a32bb900815318aefd9 
>   kcms/keyboard/keyboard_daemon.h 4edb968bb071445c52332c695e7978d26363ad09 
>   kcms/keyboard/keyboard_daemon.cpp 25673b073e104357cb3d56b13688ef7d790ee8cd 
>   kcms/keyboard/keyboard_hardware.cpp dca49b674083dbae6398e8ba0e524c647a36e47a 
>   kcms/keyboard/layout_memory.h df8568c2bdb82f0be713424e1cf6404761312ea5 
>   kcms/keyboard/layout_memory.cpp 9e723612b75b82fb04ac1fd5c2271e58e3c1aaf7 
>   kcms/keyboard/layout_memory_persister.h 8c4b3c5f60277c319b4d94ad3d40b1a65b706b8d 
>   kcms/keyboard/layout_memory_persister.cpp 8a6118aad9edea5c6a4a627144c3fd3bf837fe0e 
>   kcms/keyboard/layout_widget.cpp e67b2d77d32b87339003285712b6ef98fc292bd3 
>   kcms/keyboard/layouts_menu.h db2f3ff5844e16340ad3ca6102e6b1c4866ad8db 
>   kcms/keyboard/layouts_menu.cpp fd436c406671dcbb859dcb7367b9c83fba99da0c 
>   kcms/keyboard/x11_helper.h 719b13fec63265e0c0fed01c21e197349305928e 
>   kcms/keyboard/x11_helper.cpp 0e2806eeb55e4987c2b8f528d026ec5864d2dd9c 
>   kcms/keyboard/xinput_helper.h 343d7ed2a0528459069b0b2e3a3d4aa4d8ce43d8 
>   kcms/keyboard/xinput_helper.cpp b311579d1b65f3068d0c25b180bc1dd88fe7ba65 
>   kcms/keyboard/xkb_helper.cpp 967399ebca42e3cd18b441152a0cf3a31e28b131 
>   kcms/keyboard/xkb_rules.h 2be856246cc150abb24775c6d56b8af2a07df94f 
>   kcms/keyboard/xkb_rules.cpp f09e6750130799d6e0cdc380a6dbaa834c43aa43 
> 
> Diff: https://git.reviewboard.kde.org/r/118366/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> shivam makkar
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161021/ff873732/attachment.html>