Review Request 122642: an include is not correct

Guy Maurel guy.maurel at kde.org
Fri Oct 21 11:17:19 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122642/
-----------------------------------------------------------

(Updated Oct. 21, 2016, 11:17 a.m.)


Status
------

This change has been discarded.


Review request for KDE Frameworks.


Repository: kcoreaddons


Description
-------

trying to compile frameworks/kservice/src/services/kserviceaction.cpp
I get:
/usr/local/include/KF5/KCoreAddons/kpluginfactory.h:25:10: fatal error: 'kcoreaddons_export.h' file not found
fatal error: 'kcoreaddons_export.h' file not found#include "kcoreaddons_export.h"

I propose to change it to
#include <kcoreaddons_export.h>


Diffs
-----

  src/lib/plugin/kpluginfactory.h d2ffbdd22c8cbd553f74e11d0499dbf97adc28b5 

Diff: https://git.reviewboard.kde.org/r/122642/diff/


Testing
-------


Thanks,

Guy Maurel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161021/9e9f4b7e/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list