Review Request 127144: KSelectionProxyModel: Fix iteration bug

Stephen Kelly ske at ableton.com
Thu Oct 20 12:24:55 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127144/
-----------------------------------------------------------

(Updated Oct. 20, 2016, 12:24 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kitemmodels


Description
-------

Two bugs in one line of code.  This exists since the class was introduced, and
can result in an incomplete selection mapping, and strange behavior.


Diffs
-----

  autotests/kselectionproxymodeltest.cpp b9f1277f1469970195dfb1fd0be68c6e8411fb23 
  src/kselectionproxymodel.cpp 428b849eedd0c4f187be30a5879b72e0df268c5a 

Diff: https://git.reviewboard.kde.org/r/127144/diff/


Testing
-------


Thanks,

Stephen  Kelly

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161020/c67fcac2/attachment.html>


More information about the Kde-frameworks-devel mailing list