Review Request 123533: Add public dependency on NetworkManager

Jan Grulich jgrulich at redhat.com
Thu Oct 20 12:04:38 UTC 2016



> On Říj. 20, 2016, 11:56 dop., Albert Astals Cid wrote:
> > Patch doesn't apply anymore

That's possible, but it depends on https://git.reviewboard.kde.org/r/123532/ anyway, which I haven't finished yet as I was lazy to implement that properly.


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123533/#review100170
-----------------------------------------------------------


On Dub. 27, 2015, 2:42 odp., Jan Grulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123533/
> -----------------------------------------------------------
> 
> (Updated Dub. 27, 2015, 2:42 odp.)
> 
> 
> Review request for KDE Frameworks and Lamarque Souza.
> 
> 
> Repository: networkmanager-qt
> 
> 
> Description
> -------
> 
> This patch adds public dependency on NetworkManager and also uses FindNetworkManager.cmake from extra-cmake-modules instead own copy.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt c9e3274 
>   KF5NetworkManagerQtConfig.cmake.in cdabe8e 
>   autotests/CMakeLists.txt 8d22be3 
>   cmake/FindNetworkManager.cmake ece8835 
>   src/CMakeLists.txt e2be7d8 
>   src/fakenetwork/CMakeLists.txt 97c2867 
> 
> Diff: https://git.reviewboard.kde.org/r/123533/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161020/e69e0b7a/attachment.html>


More information about the Kde-frameworks-devel mailing list