[Differential] [Commented On] D3091: Windows: Don't display error dialogs

[kfunk (Kevin Funk)]

kfunk added a comment.


  In https://phabricator.kde.org/D3091#57277, @broulik wrote:
  
  > Can't really comment on this, though.
  
  
  
  
  > While I'm a huge fan of RAII you don't seem to be returning early from that function
  
  RAII is not only useful for cases where you return early.
  
  > ..., can't you just set the value and set it back at the end without this new class?
  
  I'm fairly sure, we'll need to guard other WinAPI calls as well. QStorageInfo from qtbase uses `SetErrorMode/GetErrorMode` a lot

REVISION DETAIL
  https://phabricator.kde.org/D3091

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: kfunk, #frameworks, brauch
Cc: nalvarez, broulik
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161017/d2ba95f6/attachment.html>