Review Request 129065: Fix frameworks compilation with Qt < 5.6

David Edmundson david at davidedmundson.co.uk
Mon Oct 17 15:46:57 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129065/
-----------------------------------------------------------

(Updated Oct. 17, 2016, 3:46 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Changes
-------

Submitted with commit f82d76eb2b915d5097f41a22a9f218e0bb23bb03 by David Edmundson on behalf of Alberto Curro to branch master.


Repository: plasma-framework


Description
-------

QQuickWindow::NoStage was new in Qt5.6. This uses a value that's valid
in earlier Qt.

This shouldn't have any behavioural effect.


Diffs
-----

  src/declarativeimports/core/windowthumbnail.cpp 0453c092f7a7144f04fdacc81b031e8c352fa23b 

Diff: https://git.reviewboard.kde.org/r/129065/diff/


Testing
-------

Ran on my nvidia machine and moused over the taskbar.

I got thumbnails as expected, but also Nvidia-settings shows "user dedicated memory" remaining constant


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161017/19a423ee/attachment.html>


More information about the Kde-frameworks-devel mailing list