Review Request 129197: Fix tests on FreeBSD
Tobias Berner
tcberner at gmail.com
Sun Oct 16 13:12:51 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129197/#review100039
-----------------------------------------------------------
I'm kind of unsure if this is right. Yes, the tests run now, but isn't the issue rather in the way kpty works (or fails to work on FreeBSD)?
- Tobias Berner
On Oct. 16, 2016, 1:44 p.m., Gleb Popov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129197/
> -----------------------------------------------------------
>
> (Updated Oct. 16, 2016, 1:44 p.m.)
>
>
> Review request for KDE Frameworks, Adriaan de Groot, Tobias Berner, Oswald Buddenhagen, and Martin Tobias Holmedahl Sandsmark.
>
>
> Repository: kpty
>
>
> Description
> -------
>
> Apparently, KPtyDevice can't be operated on after KPtyProcess finishes. Tweak tests accordingly, so they actually test things while the process is still running.
>
>
> Diffs
> -----
>
> autotests/kptyprocesstest.cpp 8b0b5b0
>
> Diff: https://git.reviewboard.kde.org/r/129197/diff/
>
>
> Testing
> -------
>
> make test on FreeBSD
>
>
> Thanks,
>
> Gleb Popov
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161016/7215652f/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list