Review Request 129177: [KNotifications] Don't use KPassivePopup without QApplication

David Edmundson david at davidedmundson.co.uk
Fri Oct 14 07:27:18 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129177/#review99997
-----------------------------------------------------------


Ship it!




Ship It!

- David Edmundson


On Oct. 14, 2016, 7:21 a.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129177/
> -----------------------------------------------------------
> 
> (Updated Oct. 14, 2016, 7:21 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: knotifications
> 
> 
> Description
> -------
> 
> When using KNotification from a QGuiApplication and there is no notification service present, the application will assert.
> 
> BUG: 370667
> 
> 
> Diffs
> -----
> 
>   src/notifybypopup.cpp 7d69a36 
> 
> Diff: https://git.reviewboard.kde.org/r/129177/diff/
> 
> 
> Testing
> -------
> 
> PowerDevil no longer crashes when a notification is emitted while no notificiation service is running.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161014/a0b132df/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list