Review Request 129173: Fix logic bug if app is built with debug and autostart is disabled.

David Edmundson david at davidedmundson.co.uk
Thu Oct 13 16:24:58 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129173/
-----------------------------------------------------------

Review request for KDE Frameworks.


Repository: kactivities


Description
-------

Was tracking down a bug, noticed something (unrelated) wrong.

The disableAutostart property is only in one of the two code paths.
Disabling debug should not have an effect on the behaviour of the
application.

This patch puts the same logic (the more common debug enabled branch) in both code paths.


Diffs
-----

  src/lib/manager_p.cpp 9d7c9f952dab1ab3df2045bcad1775d7dd962256 

Diff: https://git.reviewboard.kde.org/r/129173/diff/


Testing
-------

Logged out, logged in. All started fine.

(though I don't understand why you have a no QT_DEBUG branch when using categorised logging anyway? )


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161013/01278cfa/attachment.html>


More information about the Kde-frameworks-devel mailing list