Review Request 129159: Major performance improvement when turning previews off in the file dialog.

[Mark Gaiser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129159/#review99971
-----------------------------------------------------------


Ship it!




Looks OK to me.
Nice improvement!

- Mark Gaiser


On okt 12, 2016, 1:35 p.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129159/
> -----------------------------------------------------------
> 
> (Updated okt 12, 2016, 1:35 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Bugs: 346403
>     https://bugs.kde.org/show_bug.cgi?id=346403
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> Added a method for this KDirModel so it can emit dataChanged only once
> (or once per dir in a tree) rather than for every item.
> 
> CCBUG: 346403
> 
> 
> Diffs
> -----
> 
>   src/filewidgets/kdiroperator.cpp 59b1141e3ffb8e95680e98ed29073a977d8d52a8 
>   src/filewidgets/kfilepreviewgenerator.cpp 6937110aa53424f87575166109fa122452f9a817 
>   src/widgets/kdirmodel.h 0cefcae6b3c6e14b0505683ff533bf25e7ccf583 
>   src/widgets/kdirmodel.cpp 2e81d30990c0eb2af742fe1c811f991c0ad892e9 
> 
> Diff: https://git.reviewboard.kde.org/r/129159/diff/
> 
> 
> Testing
> -------
> 
> kdialog --getopenfilename /dir/with/many/images
> Clicking on the file dialog's "preview" button to turn them off.
> Before: 100% CPU for a minute or so
> After: immediate response
> 
> 
> Thanks,
> 
> David Faure
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161013/bc02de4d/attachment-0001.html>