Review Request 129170: Add KArchive::errorString() method to provide more details on KArchive errors
Anthony Fieroni
bvbfan at abv.bg
Thu Oct 13 06:58:35 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129170/#review99969
-----------------------------------------------------------
src/karchive.h (line 292)
<https://git.reviewboard.kde.org/r/129170/#comment67135>
First of all you must not provide const char interface and you must use i18n in all strings.
Second, i don't think library should provide strings to translate, it's an application job.
So about me, like a programmer not a maintainer, interface should be setErrorCode and client application can show user help string.
- Anthony Fieroni
On Oct. 13, 2016, 7:45 a.m., Romário Rios wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129170/
> -----------------------------------------------------------
>
> (Updated Oct. 13, 2016, 7:45 a.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: karchive
>
>
> Description
> -------
>
> This method is similar to `QIODevice::errorString()`. I added a public `errorString()` method and a protected `setErrorString()` method, to allow `KArchive`'s subclasses to implement their own error messages. I also implemented most error messages from most subclasses.
>
>
> Diffs
> -----
>
> autotests/karchivetest.cpp d0fbf41
> src/k7zip.cpp 692b1db
> src/kar.cpp 7204fb1
> src/karchive.h b528a4a
> src/karchive.cpp a1a160a
> src/karchive_p.h 256620d
> src/krcc.cpp 1947dd6
> src/ktar.cpp f70b155
> src/kzip.cpp 94d4276
>
> Diff: https://git.reviewboard.kde.org/r/129170/diff/
>
>
> Testing
> -------
>
> I added `QVERIFY` calls after all errors in `karchivetests.cpp`. Perhaps we'll need more tests, but I'm not sure how to make an archive to fail in some specific way aside from the very basics ("file not found", etc.).
>
>
> Thanks,
>
> Romário Rios
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161013/2d54d67c/attachment.html>
More information about the Kde-frameworks-devel
mailing list