Review Request 129102: Don't enforce metadata.desktop, cleanup constructor

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129102/#review99953
-----------------------------------------------------------



Either this patch or some other patch in the kplugin series broke the "externalData" for many applets!

Basically d->init(QString(), args.mid(2)); creates the applet with (QVariant(QVariantList, ()) argument and thus, since the args passed to init isn't empty, it emits onExternalData on the applet with this.

Most applets don't do anything with it but for example FolderView then sets this as its url ("cannot assign QJSValue to QString") and the FolderView becomes blank on next (or 2nd after that) startup.

- Kai Uwe Broulik


On Okt. 10, 2016, 2:28 nachm., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129102/
> -----------------------------------------------------------
> 
> (Updated Okt. 10, 2016, 2:28 nachm.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Makes it possible to use plugins that offer a metadata.json file.
> Define the service type when falling back to the desktop file parser, so the type system is proper.
> Don't destroy a KPluginMetadata tuple to instanciate it right away.
> 
> 
> Diffs
> -----
> 
>   src/plasma/applet.cpp 5eb529c 
>   src/plasma/containment.h 0b7a3ef 
>   src/plasma/containment.cpp 1840f24 
>   src/plasma/pluginloader.h 566461d 
>   src/plasma/pluginloader.cpp db2b2c9 
>   src/plasma/private/applet_p.cpp fafb450 
> 
> Diff: https://git.reviewboard.kde.org/r/129102/diff/
> 
> 
> Testing
> -------
> 
> Tests still pass, plasma still loads, even with RR #129103.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161012/bd0b9522/attachment.html>