Review Request 129122: Try to use ulog-helper if utempter does not exist

Tobias Berner tcberner at gmail.com
Sun Oct 9 13:49:12 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129122/
-----------------------------------------------------------

(Updated Oct. 9, 2016, 3:49 p.m.)


Review request for KDE Frameworks, Adriaan de Groot, Gleb Popov, and Martin Tobias Holmedahl Sandsmark.


Changes
-------

As Gleb suggested, only look in /usr/libexec for ulog-helper


Repository: kpty


Description
-------

FreeBSD does not have `/usr/libexec/*/utempter`. It does however have `/usr/libexec/ulog-helper` [1].

It uses `login` instead of `add` and `logout` instead of `del`.


[1] https://svnweb.freebsd.org/base/head/libexec/ulog-helper/ulog-helper.c?revision=234469&view=markup


Diffs (updated)
-----

  cmake/FindUTEMPTER.cmake 9773963 
  src/kpty.cpp 7bf31c3 

Diff: https://git.reviewboard.kde.org/r/129122/diff/


Testing
-------

Builds fine. Still need to test if it is actually working.


Thanks,

Tobias Berner

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161009/3311c2fd/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list