Review Request 129071: Use Gpgmepp from GpgME-1.7.0

Andreas Sturmlechner andreas.sturmlechner at gmail.com
Sat Oct 8 16:40:39 UTC 2016



> On Oct. 8, 2016, 4:19 p.m., David Faure wrote:
> > Oh sorry, I read the sentence "If Gpgmepp is not found, try to use KF5Gpgmepp" as if that meant the new bit was that fallback. Doh.
> > 
> > This is a good change then :-)

First commit converts to GpgME, then the second commit adds back KF5Gpgmepp. So when 16.12.0 is out, and/or distros have had enough time to pick up >=GpgME-1.7.0, dropping KF5Gpgmepp should be a simple revert.


- Andreas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129071/#review99853
-----------------------------------------------------------


On Sept. 29, 2016, 11:32 a.m., Andreas Sturmlechner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129071/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2016, 11:32 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kwallet
> 
> 
> Description
> -------
> 
> If Gpgmepp is not found, try to use KF5Gpgmepp
> 
> 
> Diffs
> -----
> 
>   src/runtime/kwalletd/CMakeLists.txt d7e9ca2c9891db811ecf7063d15f829cf34ad52b 
>   src/runtime/kwalletd/backend/CMakeLists.txt 20bd4d95c3c1b0cfa43cbe71ce73fa699515ecfa 
>   tests/kwalletd/CMakeLists.txt c84c1db6003412b6a7ac2768f171cbab380b376c 
> 
> Diff: https://git.reviewboard.kde.org/r/129071/diff/
> 
> 
> Testing
> -------
> 
> Builds and links fine with either GpgME-1.7.0 or KF5Gpgmepp present.
> 
> 
> Thanks,
> 
> Andreas Sturmlechner
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161008/7780d38e/attachment.html>


More information about the Kde-frameworks-devel mailing list