Review Request 129083: [KIconLoader] Take into account devicePixelRatio for overlays

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129083/
-----------------------------------------------------------

(Updated Okt. 6, 2016, 8 nachm.)


Review request for Dolphin, KDE Frameworks and David Edmundson.


Changes
-------

Don't explicitly scale emblem by devicePixelRatio.

The iconSize the logic for determining the overlay size is already scaled up (pixmap size() is the raw size, eg. 64 for a 32px pixmap on 2x dpr) so it will already pick a larger overlay. This fixes the "mounted" emblem in Dolphin's sidebar being gigantic compared to the drive icon underneath it.


Bugs: 369640
    https://bugs.kde.org/show_bug.cgi?id=369640


Repository: kiconthemes


Description
-------

Keeps them from being painted outside view and scales them with the image they're supposed to be painted on.


Diffs (updated)
-----

  src/kiconloader.cpp 5315ea4 

Diff: https://git.reviewboard.kde.org/r/129083/diff/


Testing
-------

Ran dolphin with device pixel ratio 2, got my symolic link icon again.
Ran it with device pixel ratio 1, looked as it did before.

(couldn't figure out why the VCS icons don't show up though)


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161006/d50efdb4/attachment.html>