Review Request 129110: Generate the icon into the appstream file

[Michael Stemle]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129110/#review99800
-----------------------------------------------------------



+1

- Michael Stemle


On Oct. 6, 2016, 12:54 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129110/
> -----------------------------------------------------------
> 
> (Updated Oct. 6, 2016, 12:54 a.m.)
> 
> 
> Review request for KDE Frameworks, Plasma and Matthias Klumpp.
> 
> 
> Repository: kpackage
> 
> 
> Description
> -------
> 
> Provide the icon name for now, maybe at some point it makes sense to do something fancier.
> 
> 
> Diffs
> -----
> 
>   autotests/data/testpackage/metadata.desktop 36a861f 
>   autotests/data/testpackage/testpackage.testappdataxml 7750a33 
>   src/kpackagetool/kpackagetool.cpp be492b3 
> 
> Diff: https://git.reviewboard.kde.org/r/129110/diff/
> 
> 
> Testing
> -------
> 
> tests pass, even with the addition.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161006/2c4d0ad9/attachment.html>