Review Request 129097: Define the ServiceType when found in the actual file

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129097/#review99773
-----------------------------------------------------------



eh... -1

Needs work

- Aleix Pol Gonzalez


On Oct. 4, 2016, 5:34 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129097/
> -----------------------------------------------------------
> 
> (Updated Oct. 4, 2016, 5:34 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> -------
> 
> In many occasions (e.g. `KPluginMetaData(path)`) we don't pass any service types when parsing the plugins' desktop file.
> This patch makes sure that we're using the ServiceType at least when the file is generated, giving the chance for the JSON to get properly formatted.
> 
> 
> Diffs
> -----
> 
>   src/lib/plugin/desktopfileparser.cpp 2eb198d 
>   src/lib/plugin/desktopfileparser_p.h c61b297 
> 
> Diff: https://git.reviewboard.kde.org/r/129097/diff/
> 
> 
> Testing
> -------
> 
> Tests still pass, now plasmoids have the right types on RR #129057.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161004/40f743c2/attachment.html>