Review Request 129092: Fix crashes in NotifyByAudio

[Anthony Fieroni]

> On Oct. 4, 2016, 7:32 a.m., Anthony Fieroni wrote:
> > This is not a correct place to patch it. What is your used phonon backend?
> 
> Albert Astals Cid wrote:
>     I disagree with you, none of the phonon backends call finished from stop, because finished means "i reached the end of the file" while stop just means stop.

Oh, you are right, i saw the api dox


- Anthony


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129092/#review99749
-----------------------------------------------------------


On Oct. 4, 2016, 12:31 a.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129092/
> -----------------------------------------------------------
> 
> (Updated Oct. 4, 2016, 12:31 a.m.)
> 
> 
> Review request for KDE Frameworks and Martin Klapetek.
> 
> 
> Repository: knotifications
> 
> 
> Description
> -------
> 
> Phonon::MediaObject::stop does not emit finished and thus onAudioFinished is not called and thus finished() was not called and then when closing the app, the notification manager would go and delete all the non finished notifications, meaning it would call close() again, add the same Phonon::MediaObject to m_reusablePhonons again and then crash because it would delete them twice in the destructor
> 
> 
> Diffs
> -----
> 
>   src/notifybyaudio.h 6726a93 
>   src/notifybyaudio.cpp 903e996 
> 
> Diff: https://git.reviewboard.kde.org/r/129092/diff/
> 
> 
> Testing
> -------
> 
> configure konsole notifications to emit sound on "Bell in Visible Session" and also show an info box.
> 
> Make it bell and quickly close the info box.
> 
> Close konsole.
> 
> Without this patch it will crash.
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161004/eb2ea867/attachment.html>