Review Request 129090: use ECM variables to find binary

David Edmundson david at davidedmundson.co.uk
Mon Oct 3 16:35:46 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129090/#review99741
-----------------------------------------------------------


Fix it, then Ship it!





cmake/FindUTEMPTER.cmake (line 37)
<https://git.reviewboard.kde.org/r/129090/#comment67056>

    You can do:
    
    ${KDE_INSTALL_FULL_LIBDIR}/utempter


- David Edmundson


On Oct. 3, 2016, 4:28 p.m., Jonathan Riddell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129090/
> -----------------------------------------------------------
> 
> (Updated Oct. 3, 2016, 4:28 p.m.)
> 
> 
> Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.
> 
> 
> Repository: kpty
> 
> 
> Description
> -------
> 
> use ECM variables to find binary
> 
> currently on debian distros the binary isn't found, we use arch specific directories which aren't search for with the current search string
> this finds it hidden away in /usr/lib/x86_64-linux-gnu/utempter/utempter
> 
> 
> Diffs
> -----
> 
>   cmake/FindUTEMPTER.cmake 8e16d69 
> 
> Diff: https://git.reviewboard.kde.org/r/129090/diff/
> 
> 
> Testing
> -------
> 
> build, it works
> 
> 
> Thanks,
> 
> Jonathan Riddell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161003/e282f32c/attachment.html>


More information about the Kde-frameworks-devel mailing list