Review Request 129580: Take X-KDE-RunOnDiscreteGpu property into account when starting app using klauncher

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129580/#review101180
-----------------------------------------------------------




src/klauncher/klauncher.cpp (line 746)
<https://git.reviewboard.kde.org/r/129580/#comment67802>

    The prefix s_ is usually used to mean "static".
    This QStringList is not static at all, so this is very confusing to me.
    
    Maybe rename the method argument to inputEnvs or _envs, and use envs here and below.


- David Faure


On Nov. 29, 2016, 9:51 a.m., Jan Grulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129580/
> -----------------------------------------------------------
> 
> (Updated Nov. 29, 2016, 9:51 a.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kinit
> 
> 
> Description
> -------
> 
> When running an app using klauncher, check whether X-KDE-RunOnDiscreteGpu is set and whether we have a discrete graphics card and set the environment variable accordingly.
> 
> 
> Diffs
> -----
> 
>   src/klauncher/klauncher.cpp f1727df 
> 
> Diff: https://git.reviewboard.kde.org/r/129580/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161129/415f8925/attachment.html>