Review Request 129560: More utempter path searching

[Rohan Garg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129560/#review101118
-----------------------------------------------------------


Ship it!




Diff looks a bit odd since the code indicates that those lines are already present and shouldn't be new lines. Apart from that, LGTM if it builds fine.

- Rohan Garg


On Nov. 25, 2016, 10:04 p.m., Jonathan Riddell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129560/
> -----------------------------------------------------------
> 
> (Updated Nov. 25, 2016, 10:04 p.m.)
> 
> 
> Review request for KDE Frameworks and Rohan Garg.
> 
> 
> Repository: kpty
> 
> 
> Description
> -------
> 
> Debian stable still has it in /usr/lib/utempter/ so search there
> 
> Also I don't think it wants to use CMAKE_PREFIX_PATH which is empty by default, I think this was intended to be CMAKE_INSTALL_PREFIX
> 
> old review: https://git.reviewboard.kde.org/r/129090/
> 
> 
> Diffs
> -----
> 
>   cmake/FindUTEMPTER.cmake c5a1e41 
> 
> Diff: https://git.reviewboard.kde.org/r/129560/diff/
> 
> 
> Testing
> -------
> 
> now it finds utempter in Debian stable (jessie)
> 
> 
> Thanks,
> 
> Jonathan Riddell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161125/759bee7d/attachment.html>