Review Request 129419: FrameworksIntegration: Let KPackage have dependencies from packagekit and KNewStuff

[Bhushan Shah]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129419/#review101018
-----------------------------------------------------------




src/kpackage-install-handlers/appstream/main.cpp (line 15)
<https://git.reviewboard.kde.org/r/129419/#comment67739>

    From wherever you copied this license.. it doesn't seem right :-P (along with "nullptr" library)


- Bhushan Shah


On Nov. 17, 2016, 9:30 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129419/
> -----------------------------------------------------------
> 
> (Updated Nov. 17, 2016, 9:30 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> -------
> 
> Installs binaries that will perform the installation
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 1c58560 
>   src/CMakeLists.txt 1c54eb2 
>   src/kpackage-install-handlers/CMakeLists.txt PRE-CREATION 
>   src/kpackage-install-handlers/appstream/CMakeLists.txt PRE-CREATION 
>   src/kpackage-install-handlers/appstream/main.cpp PRE-CREATION 
>   src/kpackage-install-handlers/kns/CMakeLists.txt PRE-CREATION 
>   src/kpackage-install-handlers/kns/main.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/129419/diff/
> 
> 
> Testing
> -------
> 
> It worked with the test package.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161121/41e7331e/attachment-0001.html>