Review Request 129426: refactor gpg finding

Harald Sitter sitter at kde.org
Mon Nov 21 08:50:52 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129426/
-----------------------------------------------------------

(Updated Nov. 21, 2016, 8:50 a.m.)


Review request for KDE Frameworks.


Changes
-------

switch if preference to gpgmepp, update feature hint accordingly, add package context to gpgmepp


Repository: kwallet


Description
-------

refactor gpg finding code to be correctly taking all FOUND vars into account, indicate itself as feature to cmake, prefer the new lib over the old one, not be duplicated in runtime and test dir, not require excessively shitty if's to be used.


Diffs (updated)
-----

  CMakeLists.txt 6145fda8ebd8470024396b9029d1f23298d1a333 
  src/runtime/kwalletd/CMakeLists.txt 5092a7e77a1ca7203827e444c11310566b2cc8b5 
  src/runtime/kwalletd/backend/CMakeLists.txt 2f99bc3cca89dd7a194f46cb314d2f7f90f931f3 
  tests/kwalletd/CMakeLists.txt 1e7c4b77ba478147fae964f61c28a736e32b9ea9 

Diff: https://git.reviewboard.kde.org/r/129426/diff/


Testing
-------

builds and continues to link to gpg


Thanks,

Harald Sitter

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161121/63d429bf/attachment.html>


More information about the Kde-frameworks-devel mailing list