Review Request 129394: [filenamesearch] Fix huge ram usage in kded module

Anthony Fieroni bvbfan at abv.bg
Mon Nov 21 08:19:29 UTC 2016



> On Nov. 15, 2016, 6:40 p.m., David Faure wrote:
> > This fix makes sense to me (well, I suggested it) ;)
> > 
> > As to why it doesn't work, that requires more info about how filenamesearch URLs are actually being used. Is this documented somewhere, or does it require testing and debugging?
> 
> Anthony Fieroni wrote:
>     I don't see documementation, in Dolphin it is used KDirLister::openUrl(QUrl("filenamesearch:?search=file&url=file:///path/to/file"))
> 
> Anthony Fieroni wrote:
>     https://git.reviewboard.kde.org/r/129141/

This to ship it and to search solution in Dolphin? Is there need any other improvements?


- Anthony


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129394/#review100862
-----------------------------------------------------------


On Nov. 14, 2016, 1:44 p.m., Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129394/
> -----------------------------------------------------------
> 
> Review request for KDE Frameworks, Anthony Fieroni, David Faure, and Emmanuel Pescosta.
> 
> 
> Repository: kio-extras
> 
> 
> Description
> -------
> 
> Bug is introduced in https://git.reviewboard.kde.org/r/129297/
> When is fixed new kio-extras realease is needed for 16.08 branch.
> 
> 
> Diffs
> -----
> 
>   filenamesearch/kded/filenamesearchmodule.cpp 3f9f582 
> 
> Diff: https://git.reviewboard.kde.org/r/129394/diff/
> 
> 
> Testing
> -------
> 
> No big ram usage but still not works as expected.
> 1. Perform search in Dolphin
> 2. Delete one result item
> 3. View must be update, but it's not
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161121/c0bb2810/attachment.html>


More information about the Kde-frameworks-devel mailing list