Review Request 129398: Restore KTextEditor Document Dbus bindings

Luke Dashjr luke-jr+kde at utopios.org
Fri Nov 18 08:53:50 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129398/
-----------------------------------------------------------

(Updated Nov. 18, 2016, 8:53 a.m.)


Review request for Kate, KDE Frameworks and Christoph Cullmann.


Changes
-------

Made [most] requested changes


Bugs: 369623
    https://bugs.kde.org/show_bug.cgi?id=369623


Repository: ktexteditor


Description
-------

Enable access to the document itself via dbus; this is mostly a revert of c8ce78a02794193f20caacdfb5ef68ac0d26064d and 6ff7cedb57abe7deb37e33bfa82d2f5530eb295c in the kate git repo (which removed the dbus bindings with no explanation other than "cleanups")

Intends to fix https://bugs.kde.org/show_bug.cgi?id=369623


Diffs (updated)
-----

  src/CMakeLists.txt 54cc157 
  src/document/katedocument.cpp eb30049 
  src/utils/document.cpp 44dc7cf 
  src/utils/documentadaptor_p.h PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/129398/diff/


Testing
-------

qdbus org.kde.kate-6503 /Kate/Document/2 text
qdbus org.kde.kate-6503 /Kate/Document/2 file


Thanks,

Luke Dashjr

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161118/0eb89612/attachment.html>


More information about the Kde-frameworks-devel mailing list