Review Request 129414: KMessageWidget: fix layout when word-wrap is enabled without actions

[Elvis Angelaccio]

> On Nov. 16, 2016, 1:10 p.m., Christoph Feck wrote:
> > Could you add a screen shot that shows actually wrapped text?
> 
> Christoph Feck wrote:
>     Thanks, so the close icon is vertically centered.
>     
>     Heiko, do you agree that the close icon would look better if it was also top-aligned like the message icon?
> 
> Heiko Tietze wrote:
>     Better you align it vertically with the left-hand topic icon meaning at top. That would be also place this icon according the usual position.

This is how it looks with top vertical alignment: http://i.imgur.com/i1nrxmN.png


- Elvis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129414/#review100879
-----------------------------------------------------------


On Nov. 16, 2016, 1:47 p.m., Elvis Angelaccio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129414/
> -----------------------------------------------------------
> 
> (Updated Nov. 16, 2016, 1:47 p.m.)
> 
> 
> Review request for KDE Frameworks, KDE Usability and Christoph Feck.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> -------
> 
> If we enable word-wrap on a vanilla KMessageWidget (with no additional tool buttons added), the close button is placed on row number 1 (in the grid layout), resulting in wasted space (see first messagewidget in the screenshots).
> 
> This patch places the close button on row number 1 only when we actually have other buttons in the messagewidget. This way we save space in the normal case.
> 
> 
> Diffs
> -----
> 
>   src/kmessagewidget.cpp e8b25f6427534a4991bb1dfe9f820cb651238e18 
>   tests/kmessagewidgettest.cpp 441e961ac9b851ccc713ab1713e797bd20389efd 
> 
> Diff: https://git.reviewboard.kde.org/r/129414/diff/
> 
> 
> Testing
> -------
> 
> Manual testing in the (expanded) kmessagewidgettest.
> 
> 
> File Attachments
> ----------------
> 
> Before: wasted space in the first messagewidget
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/11/16/e2fb5bce-e249-44fc-9ece-d49c0cf656e1__Spectacle.E12435.png
> After: no wasted space in the first messagewidget
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/11/16/09986a2d-f1be-48ad-92f0-87d264873ad9__Spectacle.J13060.png
> Before (with text wrapped)
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/11/16/ab594606-7f90-4ca8-949d-9baafd448252__Spectacle.X22288.png
> After (with text wrapped)
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/11/16/f574d6e6-7c92-443a-b1de-345cb3ed3ad3__Spectacle.J21199.png
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161116/c5cfaefb/attachment.html>