Review Request 129415: Allow uppercase checksums matching in Checksums tab

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129415/#review100878
-----------------------------------------------------------


Ship it!




Ship It!

- David Faure


On Nov. 16, 2016, noon, Elvis Angelaccio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129415/
> -----------------------------------------------------------
> 
> (Updated Nov. 16, 2016, noon)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Bugs: 372518
>     https://bugs.kde.org/show_bug.cgi?id=372518
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> While the checksum in cache is always guaranteed to be lowercase, the
> one from the line edit may be uppercase. If we make it lowercase
> *before* processing it, we can also simplify the regexes.
> 
> BUG: 372518
> FIXED-IN: 5.29
> 
> 
> Diffs
> -----
> 
>   src/widgets/kpropertiesdialog.cpp 18c8479bef72390a2a4f44b3a5b0d28197826d25 
>   src/widgets/kpropertiesdialog_p.h 8ad19e6974ccdeca2b98d4e4c57f8f8830cc0d31 
> 
> Diff: https://git.reviewboard.kde.org/r/129415/diff/
> 
> 
> Testing
> -------
> 
> Uppercase characters in the line edit are now matched as expected.
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161116/93a66637/attachment-0001.html>