Review Request 129397: Set environment variables from KLaunchRequest when starting new process

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129397/#review100844
-----------------------------------------------------------


Fix it, then Ship it!





src/klauncher/klauncher.cpp (line 557)
<https://git.reviewboard.kde.org/r/129397/#comment67674>

    This would break if a value contains a '=' sign, maybe better to use indexOf() and then left() and mid() ?


- David Faure


On Nov. 14, 2016, 11:45 a.m., Jan Grulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129397/
> -----------------------------------------------------------
> 
> (Updated Nov. 14, 2016, 11:45 a.m.)
> 
> 
> Review request for KDE Frameworks, David Edmundson and David Faure.
> 
> 
> Repository: kinit
> 
> 
> Description
> -------
> 
> One more patch in the series adding support for launching apps on a discrete gpu. When using KToolInvocation to start an app we call klauncher for which we need to set required env variables which needs to be set to actually run the app on the discrete gpu.
> 
> 
> Diffs
> -----
> 
>   src/klauncher/klauncher.cpp 828038b 
> 
> Diff: https://git.reviewboard.kde.org/r/129397/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161114/b09da8d4/attachment.html>