Review Request 129385: kwindowsystem add overrides
Allen Winter
winter at kde.org
Sat Nov 12 15:41:35 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129385/
-----------------------------------------------------------
Review request for KDE Frameworks.
Repository: kwindowsystem
Description
-------
Add Q_DECL_OVERRIDES as suggested by -Wsuggest-override
Diffs
-----
autotests/kwindowsystem_threadtest.cpp a142bae
src/kstartupinfo.h 9ed86e4
src/platforms/xcb/kselectionowner.h f9ca7e2
src/platforms/xcb/kxmessages.cpp 0ca6bbc
Diff: https://git.reviewboard.kde.org/r/129385/diff/
Testing
-------
all warnings for -Wsuggest-override are gone
make test passes on the same tests as previously. fyi: a handful of the same autotests fail for me with or without this patch.
Thanks,
Allen Winter
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161112/1452f287/attachment.html>
More information about the Kde-frameworks-devel
mailing list