Review Request 129170: Add KArchive::errorString() method to provide more details on KArchive errors

[Romário Rios]

> On Nov. 6, 2016, 9:49 a.m., David Faure wrote:
> > Looks ok now, except for the ATime/MTime/CTime business, and @since 5.28 should now be @since 5.29 (which is good because the translators have one month to translate all these new strings).
> > 
> > Neither ATime nor CTime is actually used in this code, feel free to remove it, maybe in a commit that you would rebase this one upon, or I can do it after you push. So at a minimum, replace MTime with "modification time", fix @since, then push.
> > 
> > Thanks!
> 
> Romário Rios wrote:
>     No problem.
>     
>     By the way, how should I apply these changes to git? Should I make one big commit or merge my local branch into master?
> 
> David Faure wrote:
>     If I was able to review it as a single commit, I'd say it should be pushed as a single commit :-)
>     
>     The removal of ATime and CTime should be a separate commit (ideally before the big one).
> 
> Romário Rios wrote:
>     Makes sense :)
>     
>     Do I have to wait for 5.28 final before pushing?
> 
> David Faure wrote:
>     No, you can push now. The release process uses temporary branches so that development never has to stop ;)

About Friederich's request to add the scripts in order to enable translations, I can do that in another commit, right?


- Romário


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129170/#review100629
-----------------------------------------------------------


On Nov. 1, 2016, 8:10 p.m., Romário Rios wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129170/
> -----------------------------------------------------------
> 
> (Updated Nov. 1, 2016, 8:10 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: karchive
> 
> 
> Description
> -------
> 
> This method is similar to `QIODevice::errorString()`. I added a public `errorString()` method and a protected `setErrorString()` method, to allow `KArchive`'s subclasses to implement their own error messages. I also implemented most error messages from most subclasses.
> 
> 
> Diffs
> -----
> 
>   autotests/karchivetest.cpp d0fbf41 
>   src/k7zip.h 5b95f49 
>   src/k7zip.cpp 692b1db 
>   src/kar.h 85bd650 
>   src/kar.cpp 7204fb1 
>   src/karchive.h b528a4a 
>   src/karchive.cpp a1a160a 
>   src/karchive_p.h 256620d 
>   src/krcc.h 18c7d00 
>   src/krcc.cpp 1947dd6 
>   src/ktar.h 4bca898 
>   src/ktar.cpp f70b155 
>   src/kzip.h 84156c7 
>   src/kzip.cpp 94d4276 
> 
> Diff: https://git.reviewboard.kde.org/r/129170/diff/
> 
> 
> Testing
> -------
> 
> I added `QVERIFY` calls after all errors in `karchivetests.cpp`. Perhaps we'll need more tests, but I'm not sure how to make an archive to fail in some specific way aside from the very basics ("file not found", etc.).
> 
> 
> Thanks,
> 
> Romário Rios
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161108/891f44ec/attachment.html>