Review Request 129186: [baloo] Speedup Positioncodec::encode()
Michael Stemle
themanchicken at gmail.com
Mon Nov 7 19:05:35 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129186/#review100694
-----------------------------------------------------------
Ship it!
Ship It!
- Michael Stemle
On Nov. 7, 2016, 6:44 p.m., Christian Ehrlicher wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129186/
> -----------------------------------------------------------
>
> (Updated Nov. 7, 2016, 6:44 p.m.)
>
>
> Review request for Baloo, KDE Frameworks and Vishesh Handa.
>
>
> Repository: baloo
>
>
> Description
> -------
>
> This patch speeds up PostingCodec::encode() by a factor of ~4 by not adding every single encoded int32 to the resulting bytearray which results in a lot of small memcpy operations.
> The idea is to use a preallocated QByteArray and directly encode the integers into this buffer. This makes the code a little bit more complex but the speedup should be gain enough for this.
>
>
> Ping! No interest in this patch? Should I discard it?
>
>
> Diffs
> -----
>
> src/codecs/coding.cpp 5961077
>
> Diff: https://git.reviewboard.kde.org/r/129186/diff/
>
>
> Testing
> -------
>
> positoncodectest calculates the same md5sum as before.
>
>
> Thanks,
>
> Christian Ehrlicher
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161107/8d7e9da6/attachment.html>
More information about the Kde-frameworks-devel
mailing list