[Differential] [Commented On] D3287: Make sure we don't break compilation with past broken units

[dfaure (David Faure)]

dfaure added a comment.


  I knew everything in your last reply already ;)
  I'm not sure you understood my suggestion though.
  
  If someone writes File=foo, your code will output
  
    Couldn't read the \"File\" field
  
  while it would be better to output
  
    Broken \"File\" field, make sure it's pointing at a *.kcfg file
  
  Of course it could then abort after that error, we only need the fallback to ${CMAKE_MATCH_1} for the compatibility thing we're talking about, when the filename is *.kcfgc.
  So my comment isn't about the compat thing but about a better error message in general. Minor, though, so you did well pushing it.

REVISION DETAIL
  https://phabricator.kde.org/D3287

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #frameworks, dfaure
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161107/ad5f6116/attachment.html>