Review Request 129299: Warn on startup about ambiguous shortcuts (with an exception for Shift+Delete)

[David Faure]

> On Nov. 1, 2016, 1:35 a.m., Aleix Pol Gonzalez wrote:
> > How about putting it in QDebug?
> > Message boxes could make us all miserable.
> 
> Albert Astals Cid wrote:
>     Making us miserable is the point, that way you'll fix it, a qdebug is something noone will even see. (Note this should not be seen *at all* if we are seeing this, there's something either wrong with this or with your app)
> 
> Aleix Pol Gonzalez wrote:
>     I understand that, but applications can't be fixed retroactively.
> 
> Albert Astals Cid wrote:
>     As far as i know, there's no application where the message is shown, maybe i can just add a "don't show me again" thing so in case a user finds a broken application she doesn't have to see the message every single time he launches it?

Yes that sounds like a good idea.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129299/#review100456
-----------------------------------------------------------


On Oct. 31, 2016, 7:18 p.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129299/
> -----------------------------------------------------------
> 
> (Updated Oct. 31, 2016, 7:18 p.m.)
> 
> 
> Review request for KDE Frameworks, David Faure and Elvis Angelaccio.
> 
> 
> Repository: kxmlgui
> 
> 
> Description
> -------
> 
> Add a warning at the createGui stage about ambiguous shortcuts being found in the same action collection.
> 
> This is usually a developer issue, but the error message about ambiguity will only show up when someone tries to use the shortcut, so it is relatively easy to miss if you do not try all your actions via a shortcut.
> 
> Also if the involved shortcut is one of the non primary shortcuts of edit_cut, just give it away, since it's usually Shift+Delete being fought over.
> 
> 
> Diffs
> -----
> 
>   src/kxmlguiwindow.cpp 519fb26 
> 
> Diff: https://git.reviewboard.kde.org/r/129299/diff/
> 
> 
> Testing
> -------
> 
> gwenview now defaults to Shift+Delete being "Hard delete" and not "Cut", if you remove the 
>   if (action == editCutAction || existingShortcutAction == editCutAction) {
> part, you get warning about the actions involved
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161107/c5ecee1e/attachment.html>