[Differential] [Accepted] D3287: Make sure we don't break compilation with past broken units

[dfaure (David Faure)]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  The error message is a bit confusing, it sounds like the right file is ${_tmp_FILE}.
  So I would suggest this instead
  
    message(WARNING "${_tmp_FILE}: Broken \"File\" field, make sure it's pointing at the right file")
  
  Also, shouldn't the regexp be File=(.*)\n ? Basically, anything in the File field that is not *.kcfg should lead to "Broken File Field", right?
  So in fact this is a bugfix (not "old broken behaviour") because it gives a better error message in case the file says File=foo : it will say "Broken File Field" instead of "Couldn't read the File field" (which would send people on the wrong track ... the field is here, it can be read, it just has the wrong contents).

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3287

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #frameworks, dfaure
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161107/f271e0ba/attachment.html>