Review Request 129355: kparts add overrides
David Faure
faure at kde.org
Sun Nov 6 22:08:03 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129355/#review100671
-----------------------------------------------------------
Ship it!
Ship It!
- David Faure
On Nov. 6, 2016, 9:06 p.m., Allen Winter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129355/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2016, 9:06 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kparts
>
>
> Description
> -------
>
> Add Q_DECL_OVERRIDES as suggested by -Wsuggest-override
>
>
> Diffs
> -----
>
> src/scriptableextension_p.h c8e58be
>
> Diff: https://git.reviewboard.kde.org/r/129355/diff/
>
>
> Testing
> -------
>
> all warnings for -Wsuggest-override are gone
> make test still passes
>
>
> Thanks,
>
> Allen Winter
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161106/d522edba/attachment.html>
More information about the Kde-frameworks-devel
mailing list