Review Request 129354: kunitconversion - add overrides

David Faure faure at kde.org
Sun Nov 6 22:07:16 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129354/#review100670
-----------------------------------------------------------


Ship it!




Ship It!

- David Faure


On Nov. 6, 2016, 8:52 p.m., Allen Winter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129354/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2016, 8:52 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kunitconversion
> 
> 
> Description
> -------
> 
> Add Q_DECL_OVERRIDES as suggested by -Wsuggest-override
> 
> 
> Diffs
> -----
> 
>   src/angle.cpp aab158f 
>   src/currency.cpp 0edfff5 
>   src/energy.cpp 08646cc 
>   src/fuel_efficiency.cpp 2dc744a 
>   src/temperature.cpp 8bf586e 
>   src/velocity.cpp aa0a69b 
> 
> Diff: https://git.reviewboard.kde.org/r/129354/diff/
> 
> 
> Testing
> -------
> 
> all warnings for -Wsuggest-override are gone
> make test still passes
> 
> 
> Thanks,
> 
> Allen Winter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161106/963f6b50/attachment.html>


More information about the Kde-frameworks-devel mailing list