Review Request 129283: kwidgetaddons - add overrides
Christoph Feck
cfeck at kde.org
Sun Nov 6 19:07:58 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129283/#review100658
-----------------------------------------------------------
Ship it!
Merci :)
- Christoph Feck
On Nov. 6, 2016, 7:26 p.m., Allen Winter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129283/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2016, 7:26 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kwidgetsaddons
>
>
> Description
> -------
>
> Add Q_DECL_OVERRIDES as suggested by -Wsuggest-override
>
>
> Diffs
> -----
>
> src/kacceleratormanager_p.h 55ab1c1
> src/kcharselect_p.h e4efdab
> src/kcursor_p.h fcac8d9
> src/kfontaction.h ae84944
> src/kmultitabbar.h 79e62ed
> src/kmultitabbar_p.h 6311413
> src/kurllabel.h eeba9e0
>
> Diff: https://git.reviewboard.kde.org/r/129283/diff/
>
>
> Testing
> -------
>
> all warnings for -Wsuggest-override are gone
> make test still passes
>
>
> Thanks,
>
> Allen Winter
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161106/6709d125/attachment.html>
More information about the Kde-frameworks-devel
mailing list