Review Request 129186: [baloo] Speedup Positioncodec::encode()
Christian Ehrlicher
ch.ehrlicher at gmx.de
Sun Nov 6 12:58:16 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129186/
-----------------------------------------------------------
(Updated Nov. 6, 2016, 12:58 p.m.)
Review request for Baloo, KDE Frameworks and Vishesh Handa.
Changes
-------
New patch with changes from comments
Repository: baloo
Description
-------
This patch speeds up PostingCodec::encode() by a factor of ~4 by not adding every single encoded int32 to the resulting bytearray which results in a lot of small memcpy operations.
The idea is to use a preallocated QByteArray and directly encode the integers into this buffer. This makes the code a little bit more complex but the speedup should be gain enough for this.
Ping! No interest in this patch? Should I discard it?
Diffs (updated)
-----
src/codecs/coding.cpp 5961077
Diff: https://git.reviewboard.kde.org/r/129186/diff/
Testing
-------
positoncodectest calculates the same md5sum as before.
Thanks,
Christian Ehrlicher
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161106/02877d0a/attachment.html>
More information about the Kde-frameworks-devel
mailing list