Review Request 129133: Silent warning of unused variable in lamda function

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129133/#review100628
-----------------------------------------------------------




src/runtime/kwalletd/migrationwizard.cpp (line 37)
<https://git.reviewboard.kde.org/r/129133/#comment67548>

    OK, but isn't this a case where a lambda is just overkill? Just forward the signal:
    
    connect(_ui._optionNo, &QRadioButton::toggled, this, &QWizardPage::completeChanged);


- David Faure


On Oct. 9, 2016, 4:04 p.m., Nilesh Kokane wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129133/
> -----------------------------------------------------------
> 
> (Updated Oct. 9, 2016, 4:04 p.m.)
> 
> 
> Review request for KDE Frameworks and Valentin Rusu.
> 
> 
> Repository: kwallet
> 
> 
> Description
> -------
> 
> ^^
> 
> 
> Diffs
> -----
> 
>   src/runtime/kwalletd/migrationwizard.cpp cdd2a92 
> 
> Diff: https://git.reviewboard.kde.org/r/129133/diff/
> 
> 
> Testing
> -------
> 
> Done
> 
> 
> Thanks,
> 
> Nilesh Kokane
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161106/53e93962/attachment.html>