Review Request 129341: [kwallet] boost::shared_ptr -> std::shared_ptr

Andreas Sturmlechner andreas.sturmlechner at gmail.com
Sat Nov 5 14:04:03 UTC 2016



> On Nov. 5, 2016, 12:56 p.m., Alexander Potashev wrote:
> > Not sure if C++11's shared_ptr can be used, at least it's not mentioned here: https://community.kde.org/Frameworks/Policies#Frameworks_compiler_requirements_and_C.2B.2B11

I'm not an expert there, but it is already used in (at least) kactivities, kdeclarative and syntax-highlighting as well.


- Andreas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129341/#review100597
-----------------------------------------------------------


On Nov. 5, 2016, 12:05 p.m., Andreas Sturmlechner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129341/
> -----------------------------------------------------------
> 
> (Updated Nov. 5, 2016, 12:05 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kwallet
> 
> 
> Description
> -------
> 
> Dropping implicit boost usage.
> 
> 
> Diffs
> -----
> 
>   src/runtime/kwalletd/backend/backendpersisthandler.cpp 413d4cd23ef1e15b75cd366061f07f179241af58 
>   src/runtime/kwalletd/knewwalletdialog.h ea71fbc7d59fdd05da7ce395e371dd7fdf91e49d 
>   src/runtime/kwalletd/knewwalletdialog.cpp 0d9ffb8ed469536cee9d4055ac0bd001fff115a0 
>   src/runtime/kwalletd/kwalletd.cpp ca7d4ffbdff4178878b3c705921ef2b1970e0dbd 
>   src/runtime/kwalletd/kwalletwizard.cpp cd52e54a668554fc0e14f4ad4cb29ba6f27fd330 
> 
> Diff: https://git.reviewboard.kde.org/r/129341/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andreas Sturmlechner
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161105/49878b27/attachment.html>


More information about the Kde-frameworks-devel mailing list