Review Request 129245: Add Korean Alphabet(Hangul) and Vietnamese Pronunciation.

[Eike Hein]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129245/#review100587
-----------------------------------------------------------




src/kcharselect.cpp (line 876)
<https://git.reviewboard.kde.org/r/129245/#comment67522>

    - s/QStringLiteral/tr (for translation)
    - Space after alphabet ("Korean Alphabet (Hangul)")



src/kcharselect.cpp (line 883)
<https://git.reviewboard.kde.org/r/129245/#comment67523>

    s/QStringLiteral/tr


- Eike Hein


On Nov. 5, 2016, 4:44 a.m., DaeHyun Sung wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129245/
> -----------------------------------------------------------
> 
> (Updated Nov. 5, 2016, 4:44 a.m.)
> 
> 
> Review request for KDE Frameworks and Christoph Feck.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> -------
> 
> Add Korean Alphabet(Hangul) and Vietnamese Pronunciation.
> ======
> 
> Unihan_Readings.txt included in Unihan.zip defines the notation and pronunciation of East Asian languages such as Chinese, Japanese, Korean, Vietnamese.
> Unihan_Readings.txt’ has some properties.
> Such as 
> kCantonese, kDefinition, kHangul, kHanyuPinlu, kHanyuPinyin, kJapaneseKun, kJapaneseOn, kKorean, kMandarin, kTang, kVietnamese, kXHC1983.
> 
> I add Unihan_Readings.txt defined kVietnamese property and kHangul property in this program.
> 
> 
> Unihan_Readings.txt’s property kVietnamese describe Vietnamese character(Qu?c ng?) pronunciation. this property defined Unihan version 3.1.1. Now Unihan database version is 9.0.0.
> Unihan_Readings.txt’s property kHangul describe Korean character(??,Hangul) describe Korean pronunciation for this character in hangul.(Hangul is Korean Alphabet) this property defined Unihan version 5.0. Now Unihan database version is 9.0.0.
> 
> 1. Why do I add kHangul(Korean Alphabet[Hangul]) property?
> Because, Unicode Consortium presented kHangul property on Unihan version 5.
> Unicode Unihan database document ( http://www.unicode.org/reports/tr38/  ) describe “kKorean” property.
> “kKorean property’s description” 
> The Korean pronunciation(s) of this character, using the Yale romanization system. (See <http://en.wikipedia.org/wiki/Korean_romanization> for a discussion of the various Korean romanization systems.)
> Use of the kKorean field is not recommended. The kHangul field, which is aligned to the KS X 1001 and KS X 1002 standards, is recommended to be used instead.
> 
> Now, Revised Romanization of Korean (RR, also called South Korean or Ministry of Culture (MC) 2000)  is the most commonly used and widely accepted system of romanization for Korean instead of "Yale romanization system"[kKorean property] in Unihan database.
> 
> So,  I add kHangul property and add “Korean Alphabet(Hangul)” notation.
> 
> 2. Why do i add kVietnamese(Vietnamese pronunciation[Qu?c ng?]) property?
> “Unicode Consortium’s version9 guide chapter18. East Asia shows these paragraph.
> In Vietnam, a set of native ideographs was created for Vietnamese based on the same principles used to create new ideographs for Chinese. These Vietnamese ideographs were used through the beginning of the 20th century and are occasionally used in more recent signage and other limited contexts.
> 
> Although the term “CJK”—Chinese, Japanese, and Korean—is used throughout this text to describe the languages that currently use Han ideographic characters, it should be noted that earlier Vietnamese writing systems were based on Han ideographs. Consequently, the term “CJKV” would be more accurate in a historical sense. Han ideographs are still used for historical, religious, and pedagogical purposes in Vietnam. “
> 
> So I read Unihan documentation specification, then  support Vietnamese language.
> 
> 
> Diffs
> -----
> 
>   src/kcharselect.cpp 30ddd34 
>   src/kcharselectdata.cpp 92c1c79 
> 
> Diff: https://git.reviewboard.kde.org/r/129245/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> DaeHyun Sung
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161105/24ed39fb/attachment.html>