Review Request 129236: KAuth: make sure we can do more than one request

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129236/
-----------------------------------------------------------

(Updated Nov. 3, 2016, 1:27 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and Olivier Goffart.


Changes
-------

Submitted with commit 0e651f1ca2b50fb996f7f18a0782b304e681bc59 by Aleix Pol to branch master.


Repository: kauth


Description
-------

It was failing because subsequent connects return false.
Only try to catch the error if a problem was reported.

Declares some enums so they print something when on QDebug.
Outputs errors into warnings instead of debug.
Removes some tr() string puzzles.

Fixes a behavior change introduced in QtDBus by:
https://code.qt.io/cgit/qt/qtbase.git/commit/?h=dev&id=6f275a4beb9a42b9d5ac99682ce9939a66239778
https://codereview.qt-project.org/#/c/161325/


Diffs
-----

  autotests/HelperTest.cpp 8050a06 
  src/backends/dbus/DBusHelperProxy.cpp c60def8 
  src/kauthaction.h 96f550b 
  src/kauthexecutejob.cpp 2901e3b 

Diff: https://git.reviewboard.kde.org/r/129236/diff/


Testing
-------

Now my snap helper can install and then uninstall an application right away.
Unit tests pass on my system.


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161103/a9030de5/attachment.html>