Review Request 129209: Rename subdir kcontrol to kcontrol5

Aleix Pol Gonzalez aleixpol at kde.org
Wed Nov 2 19:12:08 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129209/#review100513
-----------------------------------------------------------



+1 if Luigi is happy, I'm happy.

- Aleix Pol Gonzalez


On Oct. 17, 2016, 4:31 p.m., Burkhard Lück wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129209/
> -----------------------------------------------------------
> 
> (Updated Oct. 17, 2016, 4:31 p.m.)
> 
> 
> Review request for Documentation and KDE Frameworks.
> 
> 
> Repository: kdelibs4support
> 
> 
> Description
> -------
> 
> in distributions the doc packages for kdelibs4support and kde-runtime are usually designed to be co-installable, 
> but this fails in some distributions due to conflicting file paths, therefore:
>  
> * subdir kcontrol is renamed to kcontrol5
> * install target for kcm_ssl docbook changed to kcontrol5
> * X-DocPath changed to kcontrol5/kcm_ssl/index.html
> 
> 
> Diffs
> -----
> 
>   docs/CMakeLists.txt f90fa81 
>   docs/kcontrol/CMakeLists.txt  
>   docs/kcontrol/kcm_ssl/CMakeLists.txt  
>   docs/kcontrol/kcm_ssl/details.png  
>   docs/kcontrol/kcm_ssl/index.docbook  
>   docs/kcontrol/kcm_ssl/module.png  
>   docs/kcontrol5/kcm_ssl/CMakeLists.txt 4d3bc75 
>   src/kssl/kcm/kcm_ssl.desktop 6ec8be6 
> 
> Diff: https://git.reviewboard.kde.org/r/129209/diff/
> 
> 
> Testing
> -------
> 
> builds and installs properly
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161102/dc5d192e/attachment.html>


More information about the Kde-frameworks-devel mailing list