Review Request 129299: Warn on startup about ambiguous shortcuts (with an exception for Shift+Delete)

[Elvis Angelaccio]

> On Oct. 31, 2016, 6:50 p.m., Elvis Angelaccio wrote:
> > src/kxmlguiwindow.cpp, line 327
> > <https://git.reviewboard.kde.org/r/129299/diff/1/?file=483570#file483570line327>
> >
> >     I think it would be better if this were not blocking (i.e. creating the QMessageBox manually and showing it with `open()`).
> >     
> >     Otherwise the users get a messagebox instead of the main window of the app they started.
> 
> Albert Astals Cid wrote:
>     I don't know, ideally it should only be only enabled for developer builds but we do not have such flag, right?

Yeah. Btw this patch makes the app-side overrides no longer necessary, it seems. I tried to remove the override in Dolphin and shift+del still works (as force-delete). So +2 from me :)


- Elvis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129299/#review100448
-----------------------------------------------------------


On Oct. 31, 2016, 7:18 p.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129299/
> -----------------------------------------------------------
> 
> (Updated Oct. 31, 2016, 7:18 p.m.)
> 
> 
> Review request for KDE Frameworks, David Faure and Elvis Angelaccio.
> 
> 
> Repository: kxmlgui
> 
> 
> Description
> -------
> 
> Add a warning at the createGui stage about ambiguous shortcuts being found in the same action collection.
> 
> This is usually a developer issue, but the error message about ambiguity will only show up when someone tries to use the shortcut, so it is relatively easy to miss if you do not try all your actions via a shortcut.
> 
> Also if the involved shortcut is one of the non primary shortcuts of edit_cut, just give it away, since it's usually Shift+Delete being fought over.
> 
> 
> Diffs
> -----
> 
>   src/kxmlguiwindow.cpp 519fb26 
> 
> Diff: https://git.reviewboard.kde.org/r/129299/diff/
> 
> 
> Testing
> -------
> 
> gwenview now defaults to Shift+Delete being "Hard delete" and not "Cut", if you remove the 
>   if (action == editCutAction || existingShortcutAction == editCutAction) {
> part, you get warning about the actions involved
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161101/78890ed8/attachment.html>