Review Request 121218: Allow using new style connect syntax with KStandardAction::create()

Alex Richardson arichardson.kde at gmail.com
Tue May 31 14:44:16 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121218/
-----------------------------------------------------------

(Updated May 31, 2016, 2:44 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks, David Faure and Nicolás Alvarez.


Changes
-------

Submitted with commit 9395482e8b74d9954ea3b333eca286360688d0d4 by Gleb Popov to branch master.


Repository: kconfigwidgets


Description
-------

Not sure if MSVC has the necessary type_traits working, but can't test that now since it don't have a Windows machine available.


Diffs
-----

  autotests/kstandardactiontest.h 0008d281c0353e872feb7483c75762a0012a7b76 
  autotests/kstandardactiontest.cpp 09ae35db05467d61b8baf50fac70c6228e324492 
  src/kstandardaction.h d511778b7a24b1ec2e546949dab21f1ec2fea96f 
  src/kstandardaction.cpp e5bea7965032355501b4c238e37abcc0f883c0b7 

Diff: https://git.reviewboard.kde.org/r/121218/diff/


Testing
-------

The newly added unit test passes


Thanks,

Alex Richardson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160531/17104847/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list