Review Request 128055: Create ~/.local/share/mime/packages if it doesn't exist

Wolfgang Bauer wbauer at tmo.at
Mon May 30 13:17:13 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128055/
-----------------------------------------------------------

(Updated Mai 30, 2016, 3:17 nachm.)


Review request for KDE Frameworks, Plasma and David Faure.


Changes
-------

Call QDir::mkpath() unconditionally, it checks for the directory's existance anyway


Bugs: 356237
    https://bugs.kde.org/show_bug.cgi?id=356237


Repository: kde-cli-tools


Description (updated)
-------

QStandardDirs::writableLocation() doesn't guarantee that the returned directory actually exists.
So create it, otherwise saving the changes will fail if it isn't there.


Diffs (updated)
-----

  keditfiletype/mimetypewriter.cpp 11963d2 

Diff: https://git.reviewboard.kde.org/r/128055/diff/


Testing
-------

Delete ~/.local/share/mime/packages/ or ~/.local/share/mime/, if they exist.
Enter the file types editor and modify a file type (e.g. add/change the icon), then press OK or Apply.
Close it and open it again.

The changes are still there now, before they were not applied and reverted to the system defaults.


Thanks,

Wolfgang Bauer

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160530/ea0f79de/attachment.html>


More information about the Kde-frameworks-devel mailing list