Review Request 128039: Fix the window type of the progress widget
Albert Astals Cid
aacid at kde.org
Sun May 29 21:07:55 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128039/#review96006
-----------------------------------------------------------
Not an expert in the area but this is my +1, if noone gives you a Ship It in a week i guess you can take it as a Ship it.
- Albert Astals Cid
On May 29, 2016, 6:04 p.m., Martin Tobias Holmedahl Sandsmark wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128039/
> -----------------------------------------------------------
>
> (Updated May 29, 2016, 6:04 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kjobwidgets
>
>
> Description
> -------
>
> The progress widget is a dialog, so we should set the approporiate window flag.
>
>
> Diffs
> -----
>
> src/kwidgetjobtracker_p.h 2e5e026
>
> Diff: https://git.reviewboard.kde.org/r/128039/diff/
>
>
> Testing
> -------
>
> It now has the proper class and is handled appropriately.
>
>
> Thanks,
>
> Martin Tobias Holmedahl Sandsmark
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160529/611ee6da/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list