Review Request 128039: Fix the window type of the progress widget

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128039/#review95970
-----------------------------------------------------------



Maybe only do it when the parent is null?

As far as i read the code this is a qwidget and we give pass it a parent, so it'll be shown "inside" that parent by default, the thing as that the parent is a KWidgetJobTracker is "always" null since the only place we create a KWidgetJobTracker is in KDynamicJobTracker::registerJob. But as far as i see it KWidgetJobTracker is public API so it's not hard to imagine it being used somewhere where it actually has a parent.

what do you think?

- Albert Astals Cid


On May 29, 2016, 12:23 a.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128039/
> -----------------------------------------------------------
> 
> (Updated May 29, 2016, 12:23 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kjobwidgets
> 
> 
> Description
> -------
> 
> The progress widget is a dialog, so we should set the approporiate window flag.
> 
> 
> Diffs
> -----
> 
>   src/kwidgetjobtracker.cpp 585867a 
> 
> Diff: https://git.reviewboard.kde.org/r/128039/diff/
> 
> 
> Testing
> -------
> 
> It now has the proper class and is handled appropriately.
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160529/ce071d44/attachment-0001.html>